Skip to content

Fix for Open Team Membership in OwnerActorField and error messaging#107333

Merged
geoffg-sentry merged 1 commit intomasterfrom
fix-assign-permission-backend
Jan 30, 2026
Merged

Fix for Open Team Membership in OwnerActorField and error messaging#107333
geoffg-sentry merged 1 commit intomasterfrom
fix-assign-permission-backend

Conversation

@geoffg-sentry
Copy link
Contributor

#106074 wasn't properly handling for open team membership despite the intention. This intends to resolve #107226 & #107326 by:

  • Accounting for Open Team Membership being enabled OwnerActorField._validate_team_assignment() and validate_bulk_assignment() in the group index helpers
  • Improving the UI messaging when the behavior is prevented by the access control
  • Updating existing tests and adding new ones to ensure they're verified

Error messaging isn't perfect here because the OwnerActorField spans Issues, Monitors, Alerts, and Detectors but "You can only assign teams you are a member of" is still an improvement.

Front end change to follow it

@geoffg-sentry geoffg-sentry requested review from a team as code owners January 30, 2026 15:27
@geoffg-sentry geoffg-sentry changed the title fix(api): Improve team assignment validation and error messaging Fix for Open Team Membership in OwnerActorField and error messaging Jan 30, 2026
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 30, 2026
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

- Skip team membership validation when Open Team Membership is enabled

- Update error message to be more descriptive

- Add tests for OTM-enabled scenarios
@geoffg-sentry geoffg-sentry merged commit cee3853 into master Jan 30, 2026
71 checks passed
@geoffg-sentry geoffg-sentry deleted the fix-assign-permission-backend branch January 30, 2026 19:58
priscilawebdev pushed a commit that referenced this pull request Feb 2, 2026
…107333)

#106074 wasn't properly handling
for open team membership despite the intention. This intends to resolve
#107226 &
#107326 by:
- Accounting for Open Team Membership being enabled
OwnerActorField._validate_team_assignment() and
validate_bulk_assignment() in the group index helpers
- Improving the UI messaging when the behavior is prevented by the
access control
- Updating existing tests and adding new ones to ensure they're verified

Error messaging isn't perfect here because the OwnerActorField spans
Issues, Monitors, Alerts, and Detectors but "You can only assign teams
you are a member of" is still an improvement.

Front end change to follow it
geoffg-sentry added a commit that referenced this pull request Feb 4, 2026
…107335)

The front-end half of #107333 
- Extract error from responseJSON.assignedTo or responseJSON.detail
- Fix incorrect method call in group actionCreator error handler
- Shows descriptive error instead of generic 'Failed to update assignee'

---------

Co-authored-by: Scott Cooper <scttcper@gmail.com>
Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Members unable to assign issues to teams

3 participants