feat(code_review): Improve debuggability #106567
Open
+282
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
… debugging - Add extract_github_info() function to extract GitHub metadata from webhook events - Returns github_owner, github_repo_name, github_repo_full_name, and github_event_url - Update handlers.py to use extract_github_info for structured logging - Pass extracted metadata as 'extra' parameter to event handlers - Add comprehensive unit tests with 14 test cases covering: - Pull request, check run, and issue comment events - URL precedence logic (comment > check_run > pull_request) - Edge cases (missing data, empty events, etc.) - Update GitHub fixtures to include complete repository metadata - Tests use real GitHub webhook fixtures for better accuracy
- Add explicit type annotation to result dict in extract_github_info() - Add missing 'extra' parameter to _add_eyes_reaction_to_comment test calls - Fix mock setup bug in test_logs_exception_on_api_error (mock_installation vs mock_integration)
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
armenzg
commented
Jan 20, 2026
Member
Author
There was a problem hiding this comment.
I'm just adding some missing data in these fixtures.
|
|
||
| action = event.get("action") | ||
| # We can use html_url to search through the logs for this event. | ||
| extra = {"html_url": event.get("check_run", {}).get("html_url"), "action": action} |
Member
Author
There was a problem hiding this comment.
extra is already being used by the logger, thus, no more changes are needed in this file.
| """ | ||
| # The extracted important key values are used for debugging with logs | ||
| extra = extract_github_info(event) | ||
| extra["organization_slug"] = organization.slug |
Member
Author
There was a problem hiding this comment.
Currently, we only have a couple of keys to filter-by.
Here's a screenshot using these kind of keys on Sentry Logs (link):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
extract_github_info()function to extract GitHub metadata from webhook events for improved debugging and logging.In the future, we should also add this ability to Seer's code review code path.
Changes
New Function:
extract_github_info()github_owner: Repository owner/organization namegithub_repo_name: Repository namegithub_repo_full_name: Full repository name (owner/repo)github_event_url: URL to the specific event (check_run, pull_request, or comment)Integration
handle_webhook_event()inhandlers.pyto useextract_github_info()extraparameter to event handlerscheck_run.py,issue_comment.py, andpull_request.pyto acceptextraparameterTesting
Fixtures
repository.nameandrepository.owner.loginfieldsFixes CW-299