Add metric to buffer logger and fix time reset #106545
Open
+12
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
untitaker
reviewed
Jan 20, 2026
| """ | ||
| Record a single EVALSHA operation and periodically log the top offenders. | ||
| """ | ||
| metrics.timing("spans.buffer.evalsha_latency", latency_ms) |
Member
There was a problem hiding this comment.
I think this will be too many metric calls. we aggregate metrics already per batch, not per subtree (see redirect count metrics). you can do this but it will impact performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not have a metric that records the execution time of an EVALSHA.
This will alos help us understanding if the logger is behavior properly.
The last_log_time reset logic was also wrong. This fixes it.
Removed a test that was redundant. The same logic was in the previous one