-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat(code review): add eyes reaction to pr #106544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| pr_number = pull_request.get("number") | ||
| if pr_number and action in { | ||
| PullRequestAction.READY_FOR_REVIEW, | ||
| PullRequestAction.OPENED, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible there could be a race condition here--ie, we get two webhooks at the same time, one for OPENED and one for READY_FOR_REVIEW, both see that there's no eye reaction so we get two eye reactions?
If this does happen, the loop over all existing reactions in https://github.com/getsentry/seer/pull/4539 will remove all eye reactions by Sentry bot.
fixes CW-283
Depends on https://github.com/getsentry/seer/pull/4539
React with eyes emoji on PR on actions: opened, ready for review, new commit.