-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
docs(cloudflare): Change onboarding script for Cloudflare Workers #105640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+2
−2
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The Cloudflare Workers onboarding guide provides a code snippet using the
Envtype but omits the requiredwrangler typescommand to generate it, causing a TypeScript error.Severity: CRITICAL | Confidence: High
🔍 Detailed Analysis
The onboarding documentation for Cloudflare Workers provides code snippets that use the
Envtype, for example in(env: Env) =>andsatisfies ExportedHandler<Env>. However, theEnvtype is not globally available and must be generated by running thewrangler typescommand. The current onboarding instructions do not mention this prerequisite step. Consequently, users who copy and paste the provided code into their TypeScript project will encounter a compilation error: "Cannot find name 'Env'". This blocks them from successfully completing the SDK setup as documented.💡 Suggested Fix
Update the Cloudflare Workers onboarding documentation to include a step instructing the user to run
npx wrangler typesbefore they are prompted to use the code snippet. This will ensure theEnvtype definition is generated and available to the TypeScript compiler.🤖 Prompt for AI Agent
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID:
8175928