chore(explore) Remove links to traces page from explore on old spans and traces #105540
+432
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Contributor
Author
|
@sentry review |
Contributor
Author
|
@sentry review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| <Tooltip | ||
| showUnderline | ||
| isHoverable | ||
| disabled={!queryString} |
Contributor
There was a problem hiding this comment.
Tooltip disabled check always evaluates to false
The disabled={!queryString} check never works as intended because queryString is a MutableSearch object, not a string. Objects are always truthy in JavaScript, so !queryString is always false. The comparable implementation in tracesTable/fieldRenderers.tsx correctly uses search.formatString() to get a string before the check. The intended behavior to disable the tooltip when no meaningful query filters exist never triggers.
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the linking from the spans and traces table from the Explore -> Traces page. If the span or trace is older than 30 days we remove the link, and add a tooltip with a link to similar spans or traces.
Ticket: EXP-646