ref(code_review): Centralized config, prevent Seer calls and better types

[armenzg]

Refactor webhook event handling for Seer code review

Summary:
Consolidates webhook event type handling by replacing the custom EventType enum with the existing GithubWebhookType enum and centralizing configuration.

Changes:

• Replaced custom EventType enum with GithubWebhookType throughout codebase for consistency with GitHub integration types
• Created webhooks/config.py to centralize:
  • Event type to option key mappings (EVENT_TYPE_TO_OPTION)
  • Custom webhook handlers (EVENT_TYPE_TO_CUSTOM_HANDLER)
  • Task event processors (EVENT_TYPE_TO_PROCESSOR)
• Simplified webhook routing logic:
  • Extracted schedule_task() function for default webhook scheduling
  • Added call_seer_if_allowed() to check options before forwarding to Seer
  • Removed duplicate handler functions and mappings
• Reorganized options in defaults.py (moved webhook options near coding workflows section)
• Shared configuration between webhook_forwarder.py and webhook handlers via EVENT_TYPE_TO_OPTION

Benefits:

• Single source of truth for event type definitions
• Cleaner separation between validation (handlers) and processing (processors)
• Reduced code duplication
• Easier to add new webhook types

[cursor]

Inverted option check blocks Seer calls incorrectly

The condition in call_seer_if_allowed is inverted. According to the comment in defaults.py ("Control forwarding of specific GitHub webhook types to overwatch (True) or seer (False)"), when the option is True the event should go to Overwatch (not Seer), and when False it should go to Seer. However, the current logic if option_key and not options.get(option_key): return returns early when the option is False, which is the opposite of the intended behavior. With default values set to True, all events will incorrectly be forwarded to Seer when they should be blocked.

 

[cursor]

Webhook payload transformation removed, raw events sent to Seer

The old handle_other_webhook_event function called _transform_webhook_to_codegen_request to convert raw GitHub webhook payloads into the CodecovTaskRequest format expected by Seer (with data, external_owner_id, request_type, organization_id fields). The new handle_webhook_event function passes the raw event payload directly to schedule_task without any transformation. For ISSUE_COMMENT, PULL_REQUEST, PULL_REQUEST_REVIEW, and PULL_REQUEST_REVIEW_COMMENT events, Seer will now receive raw GitHub webhook payloads in the wrong format. The transformation function also filtered non-PR-related events (returning None), which is also lost.

 

[suejung-sentry]

these changes make sense to me. guessing this one will get merged first