fix(preprod): Display error for mismatched build configurations (EME-699) #105529
+25
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…699) Standardize error responses in size comparison endpoint to use 'detail' field instead of 'error' field. This ensures the error message "Head and base build configurations must be the same" is properly displayed in the UI when comparing builds with different configurations. Changes: - Backend: Convert all 'error' responses to 'detail' in size comparison endpoint - Frontend: Simplify error handling to only check 'detail' field - Tests: Update assertions to check for 'detail' instead of 'error'
github-actions
bot
added
Scope: Frontend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When comparing builds with different build configurations, the API returns a 400 error with message
{"detail":"Head and base build configurations must be the same."}but the UI was not displaying it properly.This adjusts the message in the corner to use the message from the API instead of a generic error message.
Changes
Backend
detailfield instead oferrorfield. It is a Django Framework best practice to use thedetailfield instead of theerrorfield.Here's a screenshot of what the error looks like (with spotlight dancing on top)
