Skip to content

Conversation

@JonasBa
Copy link
Member

@JonasBa JonasBa commented Dec 29, 2025

Previously, we have used differentiating keys such as priority, type, kind as well as differing values like highlight, info.

The use of such varying values and keys results in a poor developer experience, and prevents us from building a muscle for using the components. This PR modifies the Alert component and the components inheriting from it to use the variant pattern with predefined values from our design system.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 29, 2025
@JonasBa
Copy link
Member Author

JonasBa commented Dec 29, 2025

@cursoragent undo the change from muted to subtle.

@cursor
Copy link
Contributor

cursor bot commented Dec 29, 2025

Perfect! I have successfully reverted all the changes from "subtle" back to "muted". Here's a summary of what was changed:

Summary

I've successfully undone the change from muted to subtle across the entire codebase. The changes include:

Core Type and Implementation Files (6 files)

  • Type definition: static/app/utils/theme/types.tsx - Changed AlertVariant type from 'subtle' to 'muted'
  • Theme configuration: static/app/utils/theme/theme.tsx - Changed theme object key from subtle: to muted:
  • Alert components:
    • alert.tsx - Updated switch case from 'subtle' to 'muted'
    • alert.chonk.tsx - Updated case and styled component logic
    • alert.mdx - Updated documentation examples
  • Utility functions: pageAlert.tsx - Changed setPageSubtle to use 'muted' variant

Component Usage Files (24 files)

Updated all Alert component usages from variant="subtle" to variant="muted" across:

  • Event interfaces and debugging modals (2 files)
  • Form fields and external issues lists (4 files)
  • Alert rule details for crons and uptime monitoring (3 files)
  • Automation and detector components (3 files)
  • Insights and monitoring components (4 files)
  • Replay and performance components (2 files)
  • Platform picker and story components (2 files)
  • GS App components (4 files)

Status Mapping

  • Updated checkInCell.tsx to map CheckInStatus.IN_PROGRESS and CheckInStatus.UNKNOWN to 'muted' instead of 'subtle'

Total: 30 files changed, 59 insertions(+), 59 deletions(-)

All instances of the "subtle" variant have been successfully reverted to "muted" as requested.


Open in Cursor Open in Web

Learn more about Cursor Agents

Co-authored-by: jonas.badalic <jonas.badalic@sentry.io>
@cursor
Copy link
Contributor

cursor bot commented Dec 29, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@JonasBa JonasBa marked this pull request as ready for review December 29, 2025 22:27
@JonasBa JonasBa requested review from a team as code owners December 29, 2025 22:27
@JonasBa JonasBa requested review from a team as code owners December 29, 2025 22:27
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JonasBa JonasBa merged commit 92e7454 into master Dec 30, 2025
52 checks passed
@JonasBa JonasBa deleted the jb/alert/withchonk branch December 30, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants