-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
alert: remove chonk mapping #105490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alert: remove chonk mapping #105490
Conversation
|
@cursoragent undo the change from muted to subtle. |
|
Perfect! I have successfully reverted all the changes from "subtle" back to "muted". Here's a summary of what was changed: SummaryI've successfully undone the change from Core Type and Implementation Files (6 files)
Component Usage Files (24 files)Updated all Alert component usages from
Status Mapping
Total: 30 files changed, 59 insertions(+), 59 deletions(-) All instances of the "subtle" variant have been successfully reverted to "muted" as requested. Learn more about Cursor Agents |
Co-authored-by: jonas.badalic <jonas.badalic@sentry.io>
|
Cursor Agent can help with this pull request. Just |
natemoo-re
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
Previously, we have used differentiating keys such as priority, type, kind as well as differing values like highlight, info.
The use of such varying values and keys results in a poor developer experience, and prevents us from building a muscle for using the components. This PR modifies the Alert component and the components inheriting from it to use the variant pattern with predefined values from our design system.