feat(i18n): add built-in shortcodes and type-safety #105489
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add TypeScript type system to extract shortcodes from template strings - Implement SmartLink component for auto-routing internal/external links - Add DEFAULT_COMPONENTS with built-in support for [code], [link], [strong], [bold], [italic], [break] - Update gettextComponentTemplate to merge defaults with user components - Deprecate tctCode function in favor of enhanced tct - Maintain 100% backward compatibility
- Add unit tests for all 6 built-in shortcodes ([code], [link], [strong], [bold], [italic], [break]) - Test component override functionality - Test nested shortcode support - Test mixed built-in and custom shortcodes - Add type-level tests to verify compile-time enforcement - Verify backward compatibility with existing usage
- Use InlineCode component for [code] shortcode - Normalize [bold] to <strong> element - Normalize [italic] to <em> element - Add [em] as explicit shortcode option - Update BuiltInShortcodes type to include 'em'
- Update [code] tests to expect InlineCode component (with styling) - Update [bold] tests to reflect normalization to <strong> - Update [italic] tests to reflect normalization to <em> - Add test for new [em] shortcode - Make assertions more flexible for styled components
- Import InlineCode directly from @sentry/scraps/code/inlineCode - Avoids circular dependency through CodeBlock component - Keeps InlineCode styling for [code] shortcode
github-actions
bot
added
the
Scope: Frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
tctto include built-in shortcodes ('code' | 'link' | 'strong' | 'break' | 'bold' | 'italic' | 'em') based on common usage and enforce type-safety for custom shortcodes.With this, the
tctCodecan be deprecated andtct('Use [code:value]', { code: <code /> })becomestct('Use [code:value]').Usage will be migrated in a separate PR.