Skip to content

Conversation

@rbro112
Copy link
Member

@rbro112 rbro112 commented Dec 9, 2025

Investigating test results that cause shuffle-tests to fail uncovered test_resetting_context as the #1 offending test failure when tests are shuffled. After some investigation, it was clear one test in particular was not resetting the WorkflowEventContext after running.

Screenshot 2025-12-09 at 2 29 07 PM

I could then consistently reproduce the failure with

pytest tests/sentry/workflow_engine/processors/test_workflow.py tests/sentry/workflow_engine/processors/contexts/test_workflow_event_context.py

This now consistently passes when the reset is added to the test_logs_triggered_workflows test.

@rbro112 rbro112 requested a review from a team as a code owner December 9, 2025 22:25
Copy link
Member Author

rbro112 commented Dec 9, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@rbro112 rbro112 changed the title Fix WorkflowEventContext test pollution chore(infra): Fix WorkflowEventContext test pollution Dec 9, 2025
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #104641      +/-   ##
===========================================
- Coverage   80.52%    80.52%   -0.01%     
===========================================
  Files        9330      9330              
  Lines      400755    400786      +31     
  Branches    25695     25695              
===========================================
+ Hits       322721    322740      +19     
- Misses      77568     77580      +12     
  Partials      466       466              

@rbro112 rbro112 merged commit 9a318b6 into master Dec 9, 2025
67 checks passed
@rbro112 rbro112 deleted the ryan/fix_workfloweventcontext_test_pollution branch December 9, 2025 22:48
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants