chore(cells) Switch ReactView and GenericReactView to control silo #104552
+48
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We render the bulk of our HTML via ReactPage. Right now that endpoint is marked as `all_silo` to make integration with tests simpler. Switch these endpoints to control as we're trying to have a minimal number of endpoints marked as `all_silo` and I want to better understand the scope of test failures from this change. Refs INFRENG-238
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #104552 +/- ##
===========================================
+ Coverage 80.52% 80.54% +0.02%
===========================================
Files 9352 9354 +2
Lines 400460 400945 +485
Branches 25696 25696
===========================================
+ Hits 322477 322952 +475
- Misses 77533 77543 +10
Partials 450 450 |
- Change silo mode of UI endpoint tests to be control scoped as ReactPage is now control scoped. - Update a route name to not overlap with the non-customer domain path.
Subclasses of `sentry.web.frontend.base.BaseView` should not be part of the controlsilo URL map because the UI will not make requests to these paths.
github-actions
bot
added
the
Scope: Frontend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
markstory
commented
Dec 10, 2025
| r"^(?P<organization_slug>[^/]+)/projects/(?P<project_id_or_slug>[^/]+)/events/(?P<client_event_id>[^/]+)/$", | ||
| ProjectEventRedirect.as_view(), | ||
| name="sentry-project-event-redirect", | ||
| name="sentry-organization-project-event-redirect", |
Member
Author
There was a problem hiding this comment.
We had two routes with this name 🫠
markstory
added a commit
that referenced
this pull request
Dec 10, 2025
In #104552 I want to make `ReactPage` control-only. This change *should* be a no-op for saas, but I want to make sure of that first by validating with real traffic. Refs INFRENG-238
nikhars
approved these changes
Dec 10, 2025
markstory
added a commit
that referenced
this pull request
Dec 10, 2025
In #104552 I want to make `ReactPage` control-only. This change *should* be a no-op for saas, but I want to make sure of that first by validating with real traffic. Refs INFRENG-238
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We render the bulk of our HTML via ReactPage. Right now that endpoint is marked as
all_siloto make integration with tests simpler. Switch these endpoints to control as we're trying to have a minimal number of endpoints marked asall_siloand I want to better understand the scope of test failures from this change.Refs INFRENG-238