feat(releases): Add mobile tab to releases #104376

mtopo27 · 2025-12-04T05:37:49Z

context: https://www.notion.so/sentry/Integrating-with-releases-short-term-fix-2b08b10e4b5d80cbb28ccbdefe46f7f8#2b58b10e4b5d80acb810f8af7c651bac

When mobile project selected:

When non-mobile project is selected (also tested to confirm default releases page is handled when switching from mobile back to non-mobile):

static/app/views/releases/components/header.tsx

codecov · 2025-12-04T05:48:02Z

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
12840	1	12839	10

View the top 1 failed test(s) by shortest run time

ReleasesList allows searching within the mobile-builds tab

Stack Traces | 1.6s run time

Error: expect(jest.fn()).toHaveBeenLastCalledWith(...expected)

Expected: ".../mobile-project-2/preprodartifacts/list-builds/", ObjectContaining {"query": ObjectContaining {"per_page": 25, "query": "branch:main", "statsPeriod": "14d"}}
Received
       3: ".../mobile-project-2/preprodartifacts/list-builds/", {"data": undefined, "error": [Function error], "headers": undefined, "host": undefined, "method": "GET", "query": {"per_page": 25, "statsPeriod": "14d", "tab": "mobile-builds"}, "success": [Function success]}
->     4: ".../mobile-project-2/preprodartifacts/list-builds/", {"data": undefined, "error": [Function error], "headers": undefined, "host": undefined, "method": "GET", "query": {"per_page": 25, "query": "b", "statsPeriod": "14d", "tab": "mobile-builds"}, "success": [Function success]}

Number of calls: 4

Ignored nodes: comments, script, style
...
    at toHaveBeenLastCalledWith (.../releases/list/index.spec.tsx:633:26)
    at runWithExpensiveErrorDiagnosticsDisabled (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/config.js:47:12)
    at checkCallback (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/wait-for.js:124:77)
    at checkRealTimersCallback (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/wait-for.js:118:16)
    at Timeout.task [as _onTimeout] (.../sentry/node_modules/.pnpm/jsdom@26.1..../jsdom/browser/Window.js:579:19)
    at listOnTimeout (node:internal/timers:588:17)
    at processTimers (node:internal/timers:523:7)

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

rbro112 · 2025-12-10T22:29:33Z

feat(releases): Add mobile tab to releases #104376 👈 (View in Graphite)
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

rbro112 · 2025-12-10T22:29:51Z

static/app/views/releases/detail/header/releaseHeader.tsx

        numberOfMobileBuilds === 0 ? (
          <BadgeWrapper>
-            <FeatureBadge type="new" />
+            <FeatureBadge type="beta" />


Unifying on "Beta" per Max and I's discussion

rbro112 · 2025-12-10T22:31:02Z

static/app/views/releases/list/index.tsx

-              selection={selection}
-            />
-            <ReleasesPageFilterBar condensed>
+        <Layout.Header noActionWrap>


Inlines the header now and moves the project selector into it. This is intentional to give us the divider under the tabs.

rbro112 · 2025-12-10T22:39:44Z

static/app/views/releases/list/index.tsx

+              )}
+
+              {selectedTab === 'releases' && (
+                <Fragment>


All content here is the same, just gated behind the selectedTab being 'releases'

rbro112 · 2025-12-10T22:40:40Z

static/app/views/releases/list/index.tsx

-const ReleasesPageFilterBar = styled(PageFilterBar)`
-  margin-bottom: ${space(2)};
+const ReleasesPageFilterBar = styled(PageFilterBar)<{shouldShowMobileBuildsTab: boolean}>`
+  ${p => !p.shouldShowMobileBuildsTab && `margin-bottom: ${p.theme.space.xl};`}


Conditional logic to add bottom padding before the divider when tabs are not present

ryan953 · 2025-12-10T22:45:56Z

static/app/views/releases/utils/index.tsx

-  ([...mobile, ...desktop] as string[]).includes(releaseProjectPlatform);
+export const isMobileRelease = (
+  releaseProjectPlatform: PlatformKey,
+  includeDesktop = true


that's a funny prop

isMobile .... or sometimes desktop. lol

I agree but I admittedly don't have context here. Appears this change is just styling but will follow up and remove this weird includeDesktop behavior if I get the greenlight to from @mtopo27

static/app/views/releases/list/mobileBuilds.tsx

static/app/views/releases/list/index.tsx

ryan953

works for me. some nits if that's your thing.

when you're ready!

sentry · 2025-12-11T00:27:14Z

static/app/views/releases/list/index.tsx

+    if (!shouldShowMobileBuildsTab) {
+      return 'releases';
+    }
+    return (decodeScalar(location.query.tab) as ReleaseTab | undefined) || 'releases';


Bug: The tab URL query parameter is not validated at runtime. An invalid value causes the component to render a blank page instead of defaulting to the 'releases' view.
_{Severity: HIGH | Confidence: High}

🔍 Detailed Analysis

The selectedTab variable is derived from the tab URL query parameter using decodeScalar. This value is then type-cast to ReleaseTab | undefined without any runtime validation. If a user provides an invalid tab value in the URL, such as ?tab=invalid, selectedTab will hold this invalid string. Consequently, the conditional rendering for both the 'releases' and 'mobile-builds' tabs will fail, resulting in the page rendering an empty content area instead of defaulting to a valid view.

💡 Suggested Fix

Add runtime validation to ensure the value from decodeScalar(location.query.tab) is one of the expected values ('releases' or 'mobile-builds'). If it's not, default to 'releases'. For example: const tabValue = decodeScalar(location.query.tab); return (tabValue === 'mobile-builds' || tabValue === 'releases') ? tabValue : 'releases';.

🤖 Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: static/app/views/releases/list/index.tsx#L230 Potential issue: The `selectedTab` variable is derived from the `tab` URL query parameter using `decodeScalar`. This value is then type-cast to `ReleaseTab | undefined` without any runtime validation. If a user provides an invalid tab value in the URL, such as `?tab=invalid`, `selectedTab` will hold this invalid string. Consequently, the conditional rendering for both the 'releases' and 'mobile-builds' tabs will fail, resulting in the page rendering an empty content area instead of defaulting to a valid view.

_{Did we get this right? 👍 / 👎 to inform future reviews.}
_{Reference ID: 6962494}

mtopo27 added 7 commits December 3, 2025 23:17

abstract mobile project detection from release header

d736f8b

wip tab, checking new branch to refactor release header

267f932

move tabs above project selector (for now)

57f7cb9

disable env on mobile builds

da078b2

add mobile builds content

a65ef73

tab click analytics

88f1c6d

date

7c717e9

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 4, 2025

vercel bot deployed to Preview December 4, 2025 05:40 View deployment

mtopo27 commented Dec 4, 2025

View reviewed changes

static/app/views/releases/components/header.tsx Outdated Show resolved Hide resolved

Updates

06a64ef

rbro112 reviewed Dec 10, 2025

View reviewed changes

vercel bot deployed to Preview December 10, 2025 22:32 View deployment

Cleanups

5fbb978

rbro112 reviewed Dec 10, 2025

View reviewed changes

vercel bot deployed to Preview December 10, 2025 22:40 View deployment

rbro112 reviewed Dec 10, 2025

View reviewed changes

rbro112 changed the title ~~(WIP) Mtopo27/add mobile tab to releases v1~~ feat(releases): Add mobile tab to releases Dec 10, 2025

rbro112 marked this pull request as ready for review December 10, 2025 22:42

rbro112 requested a review from a team as a code owner December 10, 2025 22:42

ryan953 reviewed Dec 10, 2025

View reviewed changes

static/app/views/releases/list/mobileBuilds.tsx Outdated Show resolved Hide resolved

ryan953 reviewed Dec 10, 2025

View reviewed changes

static/app/views/releases/list/index.tsx Outdated Show resolved Hide resolved

ryan953 approved these changes Dec 10, 2025

View reviewed changes

Feedback

a421a55

vercel bot deployed to Preview December 10, 2025 23:13 View deployment

Fix

4622853

sentry bot reviewed Dec 11, 2025

View reviewed changes

vercel bot deployed to Preview December 11, 2025 00:27 View deployment

rbro112 merged commit a1510a0 into master Dec 11, 2025
48 checks passed

rbro112 deleted the mtopo27/add-mobile-tab-to-releases-v1 branch December 11, 2025 00:43

Uh oh!

feat(releases): Add mobile tab to releases #104376

feat(releases): Add mobile tab to releases #104376

Uh oh!

Conversation

mtopo27 commented Dec 4, 2025 • edited by rbro112 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 1 Tests Failed:

Uh oh!

rbro112 commented Dec 10, 2025

Uh oh!

rbro112 Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

rbro112 Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

rbro112 Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

rbro112 Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

ryan953 Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rbro112 Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ryan953 left a comment

Choose a reason for hiding this comment

Uh oh!

sentry bot Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mtopo27 commented Dec 4, 2025 •

edited by rbro112

Loading

codecov bot commented Dec 4, 2025 •

edited

Loading

ryan953 Dec 10, 2025 •

edited

Loading

rbro112 Dec 10, 2025 •

edited

Loading