refactor(replays): replace ReplayListQueryReferrer type with a const array for improved type safety #103433
+7
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #103007, I pass
queryReferreras a URL param and we lose type safety.I want to have ReplayListQueryReferrer in a tuple rather than just a type so I can use it to convert the string URL param back to a
ReplayListQueryReferrertype to be passed into a hook.This solves a bug where some replays weren't showing for particular projects because of the incorrect queryReferrer being forwarded to
useReplayList.