fix(snuba): don't mutate filter_keys #103177
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
scttcper
approved these changes
Nov 11, 2025
nora-shap
approved these changes
Nov 11, 2025
Some callsites are re-using the same dictionary. It causes problems when we `del filter_keys["group_id"]` (because that mutates the input dict). This PR runs a copy before mutating, so the original input should not be mutated.
thetruecpaul
force-pushed
the
cpaul/111125/snubanomutatefilter
branch
from
44e6663 to
e542d39
Compare
thetruecpaul
added a commit
that referenced
this pull request
Nov 11, 2025
Hotlined the fix in #103177 because it was causing problems. Best practice is to add a test here to ensure we don't regress in the future.
thetruecpaul
added a commit
that referenced
this pull request
Nov 11, 2025
Hotlined the fix in #103177 because it was causing problems. Best practice is to add a test here to ensure we don't regress in the future.
thetruecpaul
added a commit
that referenced
this pull request
Nov 11, 2025
Hotlined the fix in #103177 because it was causing problems. Best practice is to add a test here to ensure we don't regress in the future.
Jesse-Box
pushed a commit
that referenced
this pull request
Nov 12, 2025
Some callsites are re-using the same dictionary. It causes problems when we `del filter_keys["group_id"]` (because that mutates the input dict). This PR runs a copy before mutating, so the original input should not be mutated.
Jesse-Box
pushed a commit
that referenced
this pull request
Nov 12, 2025
Hotlined the fix in #103177 because it was causing problems. Best practice is to add a test here to ensure we don't regress in the future.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
Some callsites are re-using the same dictionary. It causes problems when we `del filter_keys["group_id"]` (because that mutates the input dict). This PR runs a copy before mutating, so the original input should not be mutated.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
Hotlined the fix in #103177 because it was causing problems. Best practice is to add a test here to ensure we don't regress in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some callsites are re-using the same dictionary. It causes problems when we
del filter_keys["group_id"](because that mutates the input dict).This PR runs a copy before mutating, so the original input should not be mutated.