Skip to content

Conversation

@GabeVillalobos
Copy link
Member

@GabeVillalobos GabeVillalobos commented Nov 11, 2025

Summary

  • Fixes header JSON encoding problem.
  • Adds integration test for ensuring the entire webhook forwarding logic works as intended.
  • Consolidates header constants for Github into a single file.

Details

Fixes issue with attempting to JSON encode Django headers when forwarding webhooks to prevent. Previously we were encountering pickling errors, as the request.headers is a WSGI object with extra, unnecessary fields.

This PR trims down the headers in the same way that our internal mailbox based forwarding does.

This also merges the previous webhook header constant living the webhook forwarder with our existing Github "types" file.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 11, 2025
@GabeVillalobos GabeVillalobos force-pushed the gv/fix-prevent-event-routing-logic branch from f1b52f7 to 72ed8cc Compare November 11, 2025 00:15
@GabeVillalobos GabeVillalobos marked this pull request as ready for review November 11, 2025 00:59
@GabeVillalobos GabeVillalobos requested review from a team as code owners November 11, 2025 00:59
@GabeVillalobos GabeVillalobos merged commit 4a0cb42 into master Nov 11, 2025
67 checks passed
@GabeVillalobos GabeVillalobos deleted the gv/fix-prevent-event-routing-logic branch November 11, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants