feat(billing): add orgRetention to Subscription type #103118
Open
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| export type RetentionSettings = { | ||
| downsampled: number | null; | ||
| standard: number | null; | ||
| }; |
Contributor
There was a problem hiding this comment.
Bug: Nullability Mismatch: Inconsistent Retention Type Definitions
The new RetentionSettings type defines standard: number | null, but BillingMetricHistory.retention at line 730 still uses an inline type with standard: number (non-nullable). This creates a type inconsistency where semantically similar retention fields have different nullability constraints, which could cause runtime errors when standard is null in contexts expecting the BillingMetricHistory type.
This was referenced Nov 11, 2025
Comment on lines
+161
to
+162
| downsampled: number | null; | ||
| standard: number | null; |
Member
There was a problem hiding this comment.
can you confirm these two can both be null? i'm not seeing where in the serialization on the backend they could be null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to https://github.com/getsentry/getsentry/pull/18799 and https://github.com/getsentry/getsentry/pull/18800