feat(security): Block abusive email patterns #10152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @adhiraj |
src/sentry/conf/server.py
Outdated
| @@ -1377,3 +1378,6 @@ def get_raven_config(): | |||
| JS_SDK_LOADER_SDK_VERSION = '' | |||
| # This should be the url pointing to the JS SDK | |||
| JS_SDK_LOADER_DEFAULT_SDK_URL = '' | |||
|
|
|||
| # too much junk happening from bots, lets kill things that clearly shouldn't be humans | |||
| INVALID_EMAIL_ADDRESS_PATTERN = re.compile(r'^\d\@qq\.com$', re.I) | |||
There was a problem hiding this comment.
Suggested change
| INVALID_EMAIL_ADDRESS_PATTERN = re.compile(r'^\d\@qq\.com$', re.I) | |
| INVALID_EMAIL_ADDRESS_PATTERN = re.compile(r'^\d+\@qq\.com$', re.I) |
I think you want this, otherwise it won't work for anything I've seen.
dcramer
force-pushed
the
feat/email-blocklist
branch
from
2521824 to
3c1719e
Compare
|
Its VERY possible this will block legit email addresses, but clealry people are also using this for abuse, so Im ok with that. https://www.reddit.com/r/todayilearned/comments/3xpeaf/til_that_many_chinese_people_use_phonenumber/ |
|
I'm also ok if we block qq.com entirely. |
dcramer
force-pushed
the
feat/email-blocklist
branch
from
3c1719e to
b03122c
Compare
We're seeing a lot of junk signups from \d@qq.com so this is a simply quick fix to make a configurable pattern match on blocking email addresses. It's not the be-all-end-all, but it prevents this simplistic attack. We'll likely also want to restore captcha in some cases in the future, but thats going to be a much more complex feature.
dcramer
force-pushed
the
feat/email-blocklist
branch
from
b03122c to
a0d9292
Compare
|
👍 to banning |
wedamija
added a commit
that referenced
this pull request
Jan 10, 2019
Fixes a bug in #10152, so that we actually block invalid email addresses.
wedamija
added a commit
that referenced
this pull request
Jan 10, 2019
Fixes a bug in #10152, so that we actually block invalid email addresses.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're seeing a lot of junk signups from \d@qq.com so this is a simply quick fix to make a configurable pattern match on blocking email addresses.
It's not the be-all-end-all, but it prevents this simplistic attack. We'll likely also want to restore captcha in some cases in the future, but thats going to be a much more complex feature.