Skip to content

Commit

Permalink
ref(dashboards): Remove is_creator_only_editable col from DashboardPe…
Browse files Browse the repository at this point in the history
…rmissions model (#80636)

[#80140](#80140)

Remove `is_creator_only_editable` col from `DashboardPermissions` model,
to eventually delete it

---------

Co-authored-by: harshithadurai <harshi.durai@esentry.io>
  • Loading branch information
harshithadurai and harshithadurai authored Nov 13, 2024
1 parent b933bbe commit a01d4d2
Show file tree
Hide file tree
Showing 4 changed files with 413 additions and 378 deletions.
2 changes: 1 addition & 1 deletion migrations_lockfile.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ hybridcloud: 0016_add_control_cacheversion
nodestore: 0002_nodestore_no_dictfield
remote_subscriptions: 0003_drop_remote_subscription
replays: 0004_index_together
sentry: 0787_make_dashboard_perms_col_nullable
sentry: 0788_remove__dashboard_perms_col
social_auth: 0002_default_auto_field
uptime: 0017_unique_on_timeout
workflow_engine: 0011_action_updates
37 changes: 37 additions & 0 deletions src/sentry/migrations/0788_remove__dashboard_perms_col.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
# Generated by Django 5.1.1 on 2024-11-12 22:48

from django.db import migrations

from sentry.new_migrations.migrations import CheckedMigration


class Migration(CheckedMigration):
# This flag is used to mark that a migration shouldn't be automatically run in production.
# This should only be used for operations where it's safe to run the migration after your
# code has deployed. So this should not be used for most operations that alter the schema
# of a table.
# Here are some things that make sense to mark as post deployment:
# - Large data migrations. Typically we want these to be run manually so that they can be
# monitored and not block the deploy for a long period of time while they run.
# - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
# run this outside deployments so that we don't block them. Note that while adding an index
# is a schema change, it's completely safe to run the operation after the code has deployed.
# Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment

is_post_deployment = False

dependencies = [
("sentry", "0787_make_dashboard_perms_col_nullable"),
]

operations = [
migrations.SeparateDatabaseAndState(
database_operations=[],
state_operations=[
migrations.RemoveField(
model_name="dashboardpermissions",
name="is_creator_only_editable",
),
],
),
]
1 change: 0 additions & 1 deletion src/sentry/models/dashboard_permissions.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ class DashboardPermissions(Model):

__relocation_scope__ = RelocationScope.Organization

is_creator_only_editable = models.BooleanField(default=False, null=True)
is_editable_by_everyone = models.BooleanField(default=True)
teams_with_edit_access = models.ManyToManyField(
"sentry.Team", through=DashboardPermissionsTeam, blank=True
Expand Down
Loading

0 comments on commit a01d4d2

Please sign in to comment.