Skip to content

Commit

Permalink
fix(grouping): Make built-in fingerprinting SDK test more general (#8…
Browse files Browse the repository at this point in the history
…0557)

When we worked on how we group `ChunkLoadError`s, we talked about them as if they were something unique to nextjs, but that's not actually true. They're errors thrown by Webpack, which is used by nextjs but also used by other frameworks and also used just on its own. We therefore should really be testing that our grouping works for all SDKs, not just non-nextjs SDKs. This fixes the relevant test to reflect that.
  • Loading branch information
lobsterkatie authored Nov 12, 2024
1 parent b4a4c48 commit 34532d2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/sentry/grouping/test_builtin_fingerprinting.py
Original file line number Diff line number Diff line change
Expand Up @@ -590,9 +590,9 @@ def test_built_in_chunkload_rules_value_only(self):

def test_built_in_chunkload_rules_wrong_sdk(self):
"""
Built-in ChunkLoadError rule should also apply event if SDK is not sentry.javascript.nextjs.
Built-in ChunkLoadError rule should also apply regardless of the SDK value.
"""
self.chunkload_error_trace["sdk"]["name"] = "sentry.javascript.react"
self.chunkload_error_trace["sdk"]["name"] = "not.a.real.SDK"

event = self._get_event_for_trace(stacktrace=self.chunkload_error_trace)

Expand Down

0 comments on commit 34532d2

Please sign in to comment.