Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lost in the Haystack #94

Merged
merged 21 commits into from
Sep 20, 2023
Merged

Lost in the Haystack #94

merged 21 commits into from
Sep 20, 2023

Conversation

cmanallen
Copy link
Member

@cmanallen cmanallen commented Sep 19, 2023 •
edited
Loading

Adds "Lost in the Haystack" post.

@vercel
Copy link

vercel bot commented Sep 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-engineering ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 2:49pm

@bruno-garcia
Copy link
Member

@silent1mezzo do we have vercel preview for PRs here?

@cmanallen
Copy link
Member Author

@bruno-garcia https://sentry-engineering-git-cmanallen-lost-in-the-haystack.sentry.dev/

silent1mezzo
silent1mezzo suggested changes Sep 19, 2023
View reviewed changes
data/blog/lost-in-the-haystack.md Outdated Show resolved Hide resolved
data/blog/lost-in-the-haystack.md Outdated Show resolved Hide resolved
data/blog/lost-in-the-haystack.md Outdated Show resolved Hide resolved
data/blog/lost-in-the-haystack.md Outdated Show resolved Hide resolved
data/blog/lost-in-the-haystack.md Outdated Show resolved Hide resolved
data/blog/lost-in-the-haystack.md Outdated Show resolved Hide resolved
data/blog/lost-in-the-haystack.md Outdated Show resolved Hide resolved
data/blog/lost-in-the-haystack.md Outdated Show resolved Hide resolved
data/blog/lost-in-the-haystack.md Outdated Show resolved Hide resolved
data/blog/lost-in-the-haystack.md Outdated Show resolved Hide resolved
cmanallen and others added 4 commits September 19, 2023 12:00
@cmanallen @silent1mezzo
Add database tag
cf46313 
Co-authored-by: Adam McKerlie <adammckerlie@gmail.com>
@cmanallen @silent1mezzo
Add back-ticks around replay-ids
4f8cc94 
Co-authored-by: Adam McKerlie <adammckerlie@gmail.com>
@cmanallen @silent1mezzo
Remove double see
1405ac6 
Co-authored-by: Adam McKerlie <adammckerlie@gmail.com>
@cmanallen @silent1mezzo
Fix formatting
aee479d 
Co-authored-by: Adam McKerlie <adammckerlie@gmail.com>
bruno-garcia
bruno-garcia reviewed Sep 19, 2023
View reviewed changes
data/blog/lost-in-the-haystack.md Outdated Show resolved Hide resolved
data/blog/lost-in-the-haystack.md Outdated Show resolved Hide resolved
data/blog/lost-in-the-haystack.md Show resolved Hide resolved
cmanallen and others added 5 commits September 19, 2023 12:09
@cmanallen @silent1mezzo
Fix formatting
b0d42c8 
Co-authored-by: Adam McKerlie <adammckerlie@gmail.com>
@cmanallen @silent1mezzo
'It is' not possessive its
9afdcd1 
Co-authored-by: Adam McKerlie <adammckerlie@gmail.com>
@cmanallen @silent1mezzo
Remove hyphen
0f3bf7c 
Co-authored-by: Adam McKerlie <adammckerlie@gmail.com>
@cmanallen @silent1mezzo
Remove hyphen
d8a332d 
Co-authored-by: Adam McKerlie <adammckerlie@gmail.com>
@cmanallen @silent1mezzo
Fix typo
976512c 
Co-authored-by: Adam McKerlie <adammckerlie@gmail.com>
@cmanallen @silent1mezzo
Remove hyphens
af8aab2 
Co-authored-by: Adam McKerlie <adammckerlie@gmail.com>
@silent1mezzo
Copy link
Contributor

Once merged it'll auto-deploy. Steps after that are:

  1. Share on social (Twitter, Hackernews, Reddit, etc...). it's best if it comes from you directly @cmanallen
  2. I can share in Slack with links to the social posts

bruno-garcia
bruno-garcia approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Great stuff Colton!

@cmanallen
Copy link
Member Author

@silent1mezzo @bruno-garcia I tightened the wording a little bit. This is my final change. I'm ready to merge but will wait for one final okay before doing so.

All changes on this commit: 6f9459c

@silent1mezzo
Copy link
Contributor

@cmanallen LGTM :shipit:

@cmanallen cmanallen merged commit 150f99b into main Sep 20, 2023
3 checks passed
@cmanallen cmanallen deleted the cmanallen/lost-in-the-haystack branch September 20, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@silent1mezzo silent1mezzo silent1mezzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmanallen @bruno-garcia @silent1mezzo