Skip to content
This repository was archived by the owner on Nov 20, 2023. It is now read-only.

Conversation

@scefali
Copy link
Contributor

@scefali scefali commented Oct 24, 2022

This PR set the SENTRY_PIPELINE env variable so we can set the user agent here: https://github.com/getsentry/sentry-cli/blob/6f9173687fdfd56810145c5c727ff76978784814/src/api.rs

This approach was taken from Github actions: https://github.com/getsentry/action-release/blob/master/src/cli.ts#L13

Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may just be my unfamiliarity with the way in which this is being used, but the nomenclature is a little confusing to me. Don't user agents normally include the version of the thing being the agent, not the subject of the agent's actions? And in what sense is this a pipeline?

UPDATE: Took a look at the GHA link, and yes, it should be the version of the doer, i.e., the version of @sentry/webpack-plugin, not the version of the code being packed up. You can get the correct version from package.json the same way the GHA code does.

@scefali scefali requested a review from lobsterkatie October 25, 2022 15:24
@scefali scefali merged commit 11a38b9 into getsentry:master Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants