This repository was archived by the owner on Nov 20, 2023. It is now read-only.
ref: Use var instead of const for module loader for ES5-compat #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
requested review from
a team,
AbhiPrasad and
rhcarvalho
and removed request for
a team
AbhiPrasad
approved these changes
Jan 11, 2022
|
NOTE: Integration tests worked, because we ourselves, use |
lobsterkatie
pushed a commit
to getsentry/sentry-javascript
that referenced
this pull request
Jan 28, 2022
This will pull in getsentry/sentry-webpack-plugin#338, which improved compatibility with ES5 environments.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the usage of
consttovarto preserve pre-ES6 compatibility.If we use ES6 syntax, it requires end-user to always transpile it, as we inject directly into the bundle.
Ref: #307 (comment)