Fix stack overflow when calling beforeSend during object post-loading on mobile
#782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| return handler->HandleBeforeSend(EventToProcess, HintToProcess) ? event : nullptr; | ||
| USentryEvent* ProcessedEvent = EventToProcess; | ||
| if (!FUObjectThreadContext::Get().IsRoutingPostLoad) |
Contributor
There was a problem hiding this comment.
Can't we skip the whole method in that case?
Collaborator
Author
There was a problem hiding this comment.
That makes sense, I've updated beforeSend handlers across all platforms accordingly.
Contributor
There was a problem hiding this comment.
Nitpick but I'd probably invert the check, bail early and print some debug logs. So users have a way to follow why their beforeSend is not getting called.
Collaborator
Author
There was a problem hiding this comment.
Fair enough, the check is now inverted and prints a log message explaining why custom beforeSend handling was skipped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the fix introduced in #589 to mobile platforms.