Skip to content

fix: Updated configuration window #2121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 24, 2025
Merged

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Apr 17, 2025

The options were getting a bit messy so I've added an additional tab Logging. Did some general cleanup for labels, spaces and window size as well.

Screenshot 2025-04-24 at 13 53 51
Screenshot 2025-04-24 at 13 53 54
Screenshot 2025-04-24 at 13 53 56
Screenshot 2025-04-24 at 14 12 00
Screenshot 2025-04-24 at 13 54 00
Screenshot 2025-04-24 at 13 54 02
Screenshot 2025-04-24 at 13 54 04

@bitsandfoxes bitsandfoxes marked this pull request as ready for review April 24, 2025 11:58
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the configuration window by reorganizing tabs and cleaning up UI elements to improve usability and clarity. Key changes include the addition of a new Logging tab, updated spacing and grouping for configuration options, and adjustments to the window size and advanced/native support sections.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/Sentry.Unity.Editor/ConfigurationWindow/TransportTab.cs Updated documentation text and indentation for Offline Caching.
src/Sentry.Unity.Editor/ConfigurationWindow/SentryWindow.cs Increased minimum window size and reordered the tabs.
src/Sentry.Unity.Editor/ConfigurationWindow/OptionsConfigurationTab.cs Minor indentation adjustments in the Options Config section.
src/Sentry.Unity.Editor/ConfigurationWindow/LoggingTab.cs New Logging tab implementation with configurable debouncing options.
src/Sentry.Unity.Editor/ConfigurationWindow/EnrichmentTab.cs Reorganized PII and override settings with adjusted UI texts.
src/Sentry.Unity.Editor/ConfigurationWindow/DebugSymbolsTab.cs Updated CLI config script name and indentation adjustments.
src/Sentry.Unity.Editor/ConfigurationWindow/CoreTab.cs Modified sample rate input and updated instrumentation labelling.
src/Sentry.Unity.Editor/ConfigurationWindow/AdvancedTab.cs Restructured automatic behaviours and native support into foldouts.
CHANGELOG.md Updated changelog entries reflecting the new option grouping changes.

bitsandfoxes and others added 3 commits April 24, 2025 14:11
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@bitsandfoxes bitsandfoxes merged commit 04f4a1b into main Apr 24, 2025
21 checks passed
@bitsandfoxes bitsandfoxes deleted the feat/config-window-tabs branch April 24, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants