fix: use ubuntu-20.04 container #2118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scripts/build-linux-sdk.sh
Outdated
Contributor
There was a problem hiding this comment.
I'm sorry, I did not think this through in my comment.
Now that the build & copy logic moved into a bash-script, how much effort would it be to add dotnet to the docker and leave the rest as-is? 😅
Collaborator
Author
There was a problem hiding this comment.
Not much effort at all because I already experimented with that idea yesterday 😉
Collaborator
Author
There was a problem hiding this comment.
I pushed the ubuntu:20.04 + dotnet-install.sh variant that feels nicest out of the discussed options. What do you think?
Contributor
There was a problem hiding this comment.
It's so beautiful, it's frightening! Thanks a lot!
bitsandfoxes
approved these changes
Apr 17, 2025
Contributor
bitsandfoxes
left a comment
bitsandfoxes
left a comment
There was a problem hiding this comment.
Awesome! Thanks a lot!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
dotnet-install.shfrom https://github.com/dotnet/install-scripts.#skip-changelog
Close #2114