Skip to content

fix: Fixed race condition in ANR Integration #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 3, 2025
Merged

fix: Fixed race condition in ANR Integration #2045

merged 3 commits into from
Mar 3, 2025

Conversation

bitsandfoxes
Copy link
Contributor

Fixes #2042

bruno-garcia
bruno-garcia approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not potential btw. the backing field isn't volatile so it is a race condition. and this PR fixed it.

@bitsandfoxes bitsandfoxes changed the title fix: Fixed potential race condition in ANR Integration fix: Fixed race condition in ANR Integration Mar 3, 2025
@bitsandfoxes bitsandfoxes merged commit eedc4fa into main Mar 3, 2025
73 checks passed
@bitsandfoxes bitsandfoxes deleted the fix/anr-race-condition branch March 3, 2025 08:53
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 3, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Fixed race condition in ANR Integration ([#2045](https://github.com/getsentry/sentry-unity/pull/2045))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against d81107b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The ANR detection has a race condition
2 participants
@bitsandfoxes @bruno-garcia