Capture invalid IP address exceptions #931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds exception handling for invalid IP addresses when setting user IP data from HTTP requests. The change prevents crashes when getClientIp() returns invalid IP addresses or empty strings by catching InvalidArgumentException and continuing execution without setting the IP address.
- Added try-catch block around
setIpAddress()call to handle invalid IP address exceptions - Added test case for empty remote address scenario
- Updated PHPStan baseline to account for new test case
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/EventListener/RequestListener.php | Added exception handling around IP address setting to prevent crashes from invalid IPs |
| tests/EventListener/RequestListenerTest.php | Added test case to verify behavior with empty remote address |
| phpstan-baseline.neon | Updated count for undefined constant usage in tests |
cleptric
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could throw an exception if a IP address is invalid or an empty string. Capture and ignore the exception since we can just continue without it.
As reported: getsentry/sentry-php#1750 (comment)