feat: put sentry_debug! logs behind feature flag #937
+16
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feature/chore to allow for enabling and disabling [sentry] debug logs. I was getting my container and other log systems filled with logs like this:
[sentry] [LogsBatcher] Flushing 31 logs [sentry] Get response: `{"id":"f42674c3591b41dfa855d216760a9ea8"}`Totally get having the debug logs there and I understand their use but I wanted the ability to disable them.
Perhaps another approach could be to make them traces at the trace/debug level if tracing flag is enabled that way people could opt in with level filters?
For now I've just feature flagged the macro to a no-op when used if the debug_logs flag is not enabled.
Happy for input or thoughts but I would personally love this.
Issues
N/A