Skip to content

feat(core): emit debug log when calling capture_log but logs are disabled #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2025

Conversation

lcian
Copy link
Member

@lcian lcian commented Jun 23, 2025

Maybe this can be useful in case someone forgets to set enable_logs.

Copy link

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 307f604

Copy link

codecov bot commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.20%. Comparing base (20a5d48) to head (307f604).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #849      +/-   ##
==========================================
- Coverage   74.21%   74.20%   -0.01%     
==========================================
  Files          64       64              
  Lines        7807     7808       +1     
==========================================
  Hits         5794     5794              
- Misses       2013     2014       +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lcian lcian enabled auto-merge (squash) June 23, 2025 08:45
Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcian lcian merged commit 7dbafef into master Jun 23, 2025
18 checks passed
@lcian lcian deleted the lcian/feat/logs-disabled-debug branch June 23, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants