Skip to content

fix(logs): send environment in sentry.environment default attribute #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025

Conversation

lcian
Copy link
Member

@lcian lcian commented Jun 10, 2025

Writes the environment in the right place.

Copy link

codecov bot commented Jun 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.85%. Comparing base (5cd032d) to head (9100fe7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #837      +/-   ##
==========================================
+ Coverage   72.84%   72.85%   +0.01%     
==========================================
  Files          64       64              
  Lines        7732     7732              
==========================================
+ Hits         5632     5633       +1     
+ Misses       2100     2099       -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -3137,7 +3137,7 @@ dependencies = [

[[package]]
name = "sentry"
version = "0.38.1"
version = "0.39.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can run a cargo metadata command in our "bump version" script to avoid this: https://github.com/getsentry/ophio/blob/c14d6497bdd816bdceb9217c0dbb14ca659982d3/scripts/bump-version.sh#L25

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, cool

@lcian lcian merged commit 644ee85 into master Jun 10, 2025
18 checks passed
@lcian lcian deleted the lcian/fix/logs-environment branch June 10, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants