-
-
Notifications
You must be signed in to change notification settings - Fork 166
feat(core): implement Tracing without Performance #811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #811 +/- ##
==========================================
- Coverage 73.05% 72.81% -0.25%
==========================================
Files 63 63
Lines 7267 7308 +41
==========================================
+ Hits 5309 5321 +12
- Misses 1958 1987 +29 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, I have some (mostly minor) suggestions though
Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
Co-authored-by: Daniel Szoke <7881302+szokeasaurusrex@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please address comments before merging (I marked some as nit or optional, you can ignore those if you want)
|
Implements Tracing without Performance (spec).
This is done by having an additional
PropagationContext
attribute on the scope that holds a "fake"trace_id
andspan_id
.When applying the scope to an event, if there is no ongoing span set on the scope, we create the
trace
context from thePropagationContext
.Additionally, adds an API
scope.iter_trace_propagation_headers
that should be preferred over something like:because it will use the
PropagationContext
as a fallback.Closes #796
Also makes a minor adjustment to trace and span ids where we now use the
Display
impl forDebug
, otherwise we were getting u8 arrays when using e.g.dbg!
with the derived one which is not very useful.