Skip to content

fix(otel): fix span and trace ids for distributed tracing #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 9, 2025

Conversation

lcian
Copy link
Member

@lcian lcian commented May 9, 2025

  • We're not guaranteed that OTEL trace id == Sentry trace id in the scenario where we continue a remote trace, therefore we need to go back to the static SPAN_MAP to rely on the Sentry trace_id.
  • We also need to force OTEL span id == Sentry span id when continuing a remote trace, so I've updated that API.

Noticed this during manual testing.
I should update the integration tests to cover more scenarios.

@lcian lcian requested review from Swatinem and sl0thentr0py May 9, 2025 13:11
@lcian lcian merged commit 7074891 into master May 9, 2025
14 checks passed
@lcian lcian deleted the lcian/fix/otel-ids branch May 9, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants