-
-
Notifications
You must be signed in to change notification settings - Fork 166
feat(otel): add OpenTelemetry SpanProcessor, Propagator, Extractor #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Seems like Windows CI is getting stuck on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just gave this a quick glance and left some comments on what I noticed so far.
Thank you! |
Apparently we need to put each test in a different file or they will get stuck on Windows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks reasonable to me.
Its a bit unfortunate how the lack of "onlyspans" means that you have to still deal with needing access to a TransactionOrSpan
object instead of just being able to push finished spans with opaque parent ids into a global span sink.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@lcian what is the end user experience of using this? I see you're adding stuff on the EDIT: nvm that's a docstring, ignore 🤦 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonderful, ship it
Yeah this is the snippet to set it up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work!
Creates a new crate
sentry-opentelemetry
for integration with OTEL.The implementation is based on a SpanProcessor that creates and finishes Sentry spans on OTEL span start/end.
There's also a Propagator/Extractor that injects the metadata (e.g. HTTP headers) required for distributed tracing to work.
It's based on our implementation for JS and other SDKs (https://develop.sentry.dev/sdk/telemetry/traces/opentelemetry/).
The goal with this initial version is:
Feedback appreciated on:
SPAN_MAP
, general Rust stuff, additions to performance API (@Swatinem)There are some todo items which will be addressed in follow-up PRs (not necessarily in this release).