Skip to content

Replace once_cell with std::sync::LazyLock #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

Replace once_cell with std::sync::LazyLock #776

merged 1 commit into from
Apr 25, 2025

Conversation

FalkWoldmann
Copy link
Contributor

No description provided.

Swatinem
Swatinem approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but we should check whether it aligns with our advertised MSRV.

otherwise, as the Cargo.lock shows, we still depend on it transitively, and probably will for a while, as these changes are really slow to propagate through the ecosystem.

@FalkWoldmann
Copy link
Contributor Author

As far as I can tell, the README mentions an MSRV of 1.81, and since LazyLock stabilized in 1.80, it seems like it should be okay —does that sound right? :)

@Swatinem Swatinem merged commit f005af8 into getsentry:master Apr 25, 2025
18 checks passed
@Swatinem
Copy link
Member

Yes. Our CI was also green, so lets go :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swatinem Swatinem Swatinem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FalkWoldmann @Swatinem