chore(msrv): cargo update and bump MSRV to 1.81
#754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
approved these changes
Mar 19, 2025
There was a problem hiding this comment.
In general I’m 👍🏻 on bumping msrv.
Though the very latest cargo with resolver=3 is "msrv aware", meaning that it picks msrv compatible versions when doing a cargo update, etc.
Though that latest cargo version is 1.85, and requires that explicit resolver setting for workspaces, or the 2024 edition for crates, which I think we are still quite far away from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MSRV is actually 1.81, I didn't run
cargo updatethe last time 😄