Skip to content

doc(tracing): Add docs for errors and custom tags with tracing #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2023

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented May 30, 2023

Follow-up to #585

@jan-auer jan-auer self-assigned this May 30, 2023
@jan-auer jan-auer requested a review from Swatinem May 30, 2023 10:28
@jan-auer jan-auer changed the title doc(tracing): Describe tags and errors for tracing doc(tracing): Add docs for errors and custom tags with tracing May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #586 (2967e26) into master (0040485) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 2967e26 differs from pull request most recent head 70be215. Consider uploading reports for the commit 70be215 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #586   +/-   ##
=======================================
  Coverage   70.48%   70.48%           
=======================================
  Files          67       67           
  Lines        6809     6809           
=======================================
  Hits         4799     4799           
  Misses       2010     2010           

Copy link
Contributor

@olksdr olksdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jan-auer jan-auer merged commit 117f2d0 into master May 31, 2023
@jan-auer jan-auer deleted the doc/tracing-improvements branch May 31, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants