-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sentry-core: support custom user data in TransactionContext #512
Conversation
79a8c6d
to
62a3aab
Compare
sentry-core/src/performance.rs
Outdated
|
||
/// Update the custom context of this Transaction. | ||
/// | ||
/// For simply adding a key, use the `set_custom_key` method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is set_custom_key
meant to be the custom_insert
method below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes. Will fix - I renamed it after I changed the signature to be in line with hashmap's insert
(return previous value)
@tommilligan thanks for working on this! would it make sense to extract the public getter functions to a dedicated PR to unblock them from getting merged and released? not sure how much discussion the custom user data feature needs... :) |
Fair point. Split the public getters into #514 |
affc1fb
to
5949535
Compare
Rebased on master to fix conflicts. |
Relates to recent work in #510
Adds support for the
traces_sampler
inspecting:TransactionContext
name
operation
sampled
This is consistent with the Python implementation for custom sampling context.
Adds support for this custom payload by:
sampled
is; this is back compatibleNone
by default, to minimise performance impactserde_json::Value
:sentry-core
crate for internals of the v7 protocolpython
implementation (arbitary data, in a top level object with string keys)