Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Turn of pprof default features #491

Merged
merged 1 commit into from
Aug 11, 2022
Merged

fix: Turn of pprof default features #491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Turn of pprof default features 
One of the pprof default features (`cpp`) pulls in `symbolic-demangle`,
which is used for demangling, but we don't use that feature at all since
we are only interested in raw instruction addrs which we symbolicate and
demangle server-side.
  • Loading branch information
@Swatinem
Swatinem committed Aug 11, 2022
commit 4bb80be2a7df788999d68d0e3ed3b790dbc60b2f
4 changes: 2 additions & 2 deletions sentry-core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@ build_id = { version = "0.2.1", optional = true }
findshlibs = { version = "=0.10.2", optional = true }

[target.'cfg(all(not(target_os = "windows"), not(all(target_os = "macos", target_arch = "aarch64"))))'.dependencies]
pprof = { version = "0.10.0", optional = true }
pprof = { version = "0.10.0", optional = true, default-features = false }

[target.'cfg(all(target_os = "macos", target_arch = "aarch64"))'.dependencies]
pprof = { version = "0.10.0", optional = true, features = ["frame-pointer"]}
pprof = { version = "0.10.0", optional = true, default-features = false, features = ["frame-pointer"]}

[dev-dependencies]
# Because we re-export all the public API in `sentry`, we actually run all the
Expand Down