Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(profiling): Add support for Profiling #479

Merged
merged 12 commits into from
Jul 1, 2022
Merged

feat(profiling): Add support for Profiling #479

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cbba709
Add support for Profiling
viglia Jun 27, 2022
98d750a
Fix cargo doc warnings
viglia Jun 27, 2022
552e936
fix linting
viglia Jun 27, 2022
c9e7f43
Add target_os conditional compilation
viglia Jun 27, 2022
0020a8d
Fix error reported by make lint
viglia Jun 27, 2022
d29e807
Exclude pprof dependency when compiling on windows
viglia Jun 27, 2022
ebe52bf
Address PR feedback
viglia Jun 30, 2022
c52880c
Refactor start_profiling finish_profiling
viglia Jun 30, 2022
f71f8d4
Remove unused dependencies
viglia Jun 30, 2022
1b49423
Remove unused code
viglia Jun 30, 2022
b51befa
Update the CHANGELOG
viglia Jun 30, 2022
f5b063c
Refactor `thank you` section of the CHANGELOG
viglia Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix linting
  • Loading branch information
@viglia
viglia committed Jun 27, 2022
commit 552e9363ba58ca9f08c435f5a699fd76e45ab08b
2 changes: 1 addition & 1 deletion sentry-core/src/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ impl Client {
}

if !self.sample_should_send(self.options.sample_rate) {
return None;
None
} else {
Some(event)
}
Expand Down
4 changes: 2 additions & 2 deletions sentry-types/src/protocol/profile.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,13 +98,13 @@ impl Profile {
"{}",
serde_json::to_string(&ProfileItemHeader {
content_type: "application/json".to_string(),
file_name: format!("{}.trace", self.trace_id).to_string(),
file_name: format!("{}.trace", self.trace_id),
typez: "profile".to_string(),
length: serialized_profile.len(),
})?
)?;

writer.write_all(&serialized_profile.as_bytes())?;
writer.write_all(serialized_profile.as_bytes())?;
Ok(())
}
}