feat: Add support of tracing::Span::record operation for sentry-tracing

sentry-tracing/src/converters.rs

@@ -54,7 +54,7 @@ pub fn extract_span_data(attrs: &span::Attributes) -> (Option<String>, BTreeMap<
 
 #[derive(Default)]
 /// Records all fields of [`tracing_core::Event`] for easy access
-struct BTreeMapRecorder(pub BTreeMap<String, Value>);
+pub(crate) struct BTreeMapRecorder(pub BTreeMap<String, Value>);
 
 impl BTreeMapRecorder {
     fn record<T: Into<Value>>(&mut self, field: &Field, value: T) {

sentry-tracing/src/layer.rs

@@ -410,6 +410,27 @@ where
             client.send_envelope(envelope);
         });
     }
+
+    /// Implement the writing of extra data to span
+    fn on_record(&self, span: &span::Id, values: &span::Record<'_>, ctx: Context<'_, S>) {
+        let span = match ctx.span(span) {
+            Some(s) => s,
+            _ => return,
+        };
+
+        let mut extensions_holder = span.extensions_mut();
+        let trace = match extensions_holder.get_mut::<Trace>() {
+            Some(t) => t,
+            _ => return,
+        };
+
+        let mut data = BTreeMapRecorder::default();
+        values.record(&mut data);
+
+        for (key, value) in data.0 {
+            trace.span.data.insert(key, value);
+        }
+    }
 }
 
 /// Timing informations for a given Span

sentry/tests/test_tracing.rs

@@ -7,10 +7,9 @@ use tracing_subscriber::prelude::*;
 #[test]
 fn test_tracing() {
     // Don't configure the fmt layer to avoid logging to test output
-    tracing_subscriber::registry()
+    let _dispatcher = tracing_subscriber::registry()
         .with(sentry_tracing::layer())
-        .try_init()
-        .unwrap();
+        .set_default();
 
     let events = sentry::test::with_captured_events(|| {
         sentry::configure_scope(|scope| {
@@ -54,3 +53,41 @@ fn test_tracing() {
         Some("Hello Logging World!".into())
     );
 }
+
+#[tracing::instrument(fields(span_field))]
+fn function() {
+    tracing::Span::current().record("span_field", &"some data");
+}
+
+#[test]
+fn test_span_record() {
+    let _dispatcher = tracing_subscriber::registry()
+        .with(sentry_tracing::layer())
+        .set_default();
+
+    let options = sentry::ClientOptions {
+        traces_sample_rate: 1.0,
+        ..Default::default()
+    };
+
+    let envelopes = sentry::test::with_captured_envelopes_options(
+        || {
+            let _span = tracing::span!(tracing::Level::INFO, "span").entered();
+            function();
+        },
+        options,
+    );
+
+    assert_eq!(envelopes.len(), 1);
+
+    let envelope_item = envelopes[0].items().next().unwrap();
+    let transaction = match envelope_item {
+        sentry::protocol::EnvelopeItem::Transaction(t) => t,
+        _ => panic!("expected only a transaction item"),
+    };
+
+    assert_eq!(
+        transaction.spans[0].data["span_field"].as_str().unwrap(),
+        "some data"
+    );
+}