feat: Add support for pre-aggregated Sessions #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
commented
Oct 20, 2020
Swatinem
force-pushed
the
feat/aggregates
branch
from
6adbe2d to
8141d69
Compare
flub
reviewed
Nov 19, 2020
jan-auer
reviewed
Nov 30, 2020
| @@ -91,6 +116,8 @@ pub struct ClientOptions { | |||
| /// is started at the time of `sentry::init`, and will persist for the | |||
| /// application lifetime. | |||
| pub auto_session_tracking: bool, | |||
| /// Determine how Sessions are being tracked. | |||
| pub session_mode: SessionMode, | |||
There was a problem hiding this comment.
Could we consider combining this with the session tracking flag into a session_mode: Application | Request | Off?
There was a problem hiding this comment.
I thought about this a bit, and a tri-state would not work when you don’t want to have auto-tracking, but want to manually track request-mode sessions.
Also related to your other question: Request-Mode applies to all sessions, I updated the doc comment to accordingly. So choosing between application/request-mode basically means that you make a choice if you want aggregation at the cost of losing durations, or not.
Adds a new `session_mode` option that can be set to pre-aggregate sessions before they are sent upstream. This will allow efficient server applications that can produce thousands of session updates per second.
Swatinem
force-pushed
the
feat/aggregates
branch
from
645d2d4 to
4260bbe
Compare
jan-auer
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should work together with getsentry/relay#815