fix: Improve transport synchronization and consume response #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
approved these changes
Sep 14, 2020
Comment on lines
+255
to
+256
| Err(err) => { sentry_debug!("Failed to read sentry response: {}", err); }, | ||
| Ok(text) => { sentry_debug!("Get response: `{}`", text); }, |
There was a problem hiding this comment.
Suggested change
| Err(err) => { sentry_debug!("Failed to read sentry response: {}", err); }, | |
| Ok(text) => { sentry_debug!("Get response: `{}`", text); }, | |
| Err(err) => sentry_debug!("Failed to read sentry response: {}", err), | |
| Ok(text) => sentry_debug!("Get response: `{}`", text), |
There was a problem hiding this comment.
I'm wondering how this does not fail rustfmt.
There was a problem hiding this comment.
its inside the macro, so none of that stuff is rustfmt-ed, also, I needed to wrap this in a block because of the way the sentry_debug macro is built :-(
There was a problem hiding this comment.
I see, thanks. At least the comment after the } should go usually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The synchronization fixes have been proposed in #172 originally