Fix Sidekiq tracing headers not being overwritten in case of schedules and retries #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and retries [#2118](#2118) #1774 added `SentryContextClientMiddleware` to the server middleware chain too. Sidekiq's scheduler pushes to the client on the server again for schedules and retries which causes our trace propagation to be broken for this case. https://github.com/sidekiq/sidekiq/blob/aadc77a172f1490fb141c7936d2801ca3af925ef/lib/sidekiq/scheduled.rb#L39 Prioritize taking the trace propagation headers from the job whenever they exist.
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1774 added
SentryContextClientMiddlewareto the server middleware chain too.Sidekiq's scheduler pushes to the client on the server again for schedules and retries which causes our trace propagation to be broken for this case.
Prioritize taking the trace propagation headers from the job whenever they exist.