Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move http query to span data #2039

Merged
merged 1 commit into from
May 15, 2023
Merged

Move http query to span data #2039

merged 1 commit into from
May 15, 2023

Conversation

sl0thentr0py
Copy link
Member

Align with the query/fragment http spec.

Notes:

  • username/password in the url is not an issue since we already don't expose those
  • fragment is currently not extractable from req in our net/http patch, so just ignore for now

fixes #1955

@sl0thentr0py sl0thentr0py requested a review from st0012 May 12, 2023 14:21
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -9.49 ⚠️

Comparison is base (32375a8) 83.20% compared to head (c11e867) 73.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2039      +/-   ##
==========================================
- Coverage   83.20%   73.72%   -9.49%     
==========================================
  Files         119       91      -28     
  Lines        5638     4144    -1494     
==========================================
- Hits         4691     3055    -1636     
- Misses        947     1089     +142     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/net/http.rb 28.88% <0.00%> (-2.07%) ⬇️

... and 42 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@st0012 st0012 added this to the 6.0.0 milestone May 13, 2023
@sl0thentr0py sl0thentr0py merged commit c0dd6df into master May 15, 2023
@sl0thentr0py sl0thentr0py deleted the neel/sanitize-urls branch May 15, 2023 14:10
@st0012 st0012 modified the milestones: 6.0.0, 5.10.0 May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sanitize URLs in Span description and breadcrumbs
3 participants