Improve ActiveSupport breadcrumb logger's data filtering #2030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As explained in #1183 (comment), sometimes other gems could inject their own data into the payload, which may cause problems when we try to serialize them. It's possible that Array and Hash also contain such objects, but I'm not excluding them yet because: 1. I haven't seen other gems injecting their own data into the payload in this way. 2. Some Rails events (e.g. `deliver.action_mailer`) use Array or Hash in the payload, so ignore them now could reduce the data users can get.
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Improve ActiveSupport breadcrumb logger's data filtering ([#2030](https://github.com/getsentry/sentry-ruby/pull/2030))If none of the above apply, you can opt out of this check by adding |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2030 +/- ##
==========================================
- Coverage 98.58% 98.58% -0.01%
==========================================
Files 157 157
Lines 10127 10142 +15
==========================================
+ Hits 9984 9998 +14
- Misses 143 144 +1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
sl0thentr0py
approved these changes
Apr 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sql.active_recordpayload'sconnectionandbindsbecause they could cause problems when being serialised.I know 2) also excludes most data declared in
IGNORED_KEYS, but I think it's still worth keeping that list to make it explicit on what we try to exclude.