Skip to content

Validate contexts when setting multiple contexts #2022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 20, 2023

Conversation

returnv01d
Copy link
Contributor

Description

Adds validation for contexts set by set_contexts method
Fixes #2021

@sl0thentr0py
Copy link
Member

thx @returnv01d!

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (00843f3) 98.56% compared to head (e1167c9) 98.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2022   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files         157      157           
  Lines       10105    10110    +5     
=======================================
+ Hits         9960     9965    +5     
  Misses        145      145           
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/scope.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/scope/setters_spec.rb 97.58% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sl0thentr0py sl0thentr0py merged commit 9c90d2d into getsentry:master Mar 20, 2023
@st0012 st0012 added this to the 5.9.0 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Context values validation in set_contexts method
3 participants