Skip to content

Conversation

@sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Feb 15, 2023

The new optional boolean will set traces_sample_rate to 1.0
automatically if not set yet. If false, this will also disable tracing
even if a sample rate or sampler is set.

closes #1996

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (a471812) 98.56% compared to head (2bf8dca) 98.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2005   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files         157      157           
  Lines       10075    10105   +30     
=======================================
+ Hits         9930     9960   +30     
  Misses        145      145           
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/configuration.rb 98.57% <100.00%> (+0.04%) ⬆️
sentry-ruby/spec/sentry/configuration_spec.rb 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I do not get is what "sending not allowed" means, but otherwise it looks good.

Copy link
Contributor

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some suggestions on the changelog

@sl0thentr0py
Copy link
Member Author

master rails is broken :( I will fix later

@st0012
Copy link
Contributor

st0012 commented Feb 18, 2023

@sl0thentr0py After checking the error, it seems to be caused by Rails itself, see: rails/rails#47377. And there is already a PR for it: rails/rails#47409

So IMO we can wait a couple of days for the issue to be resolved upstream.

@st0012 st0012 added this to the 5.9.0 milestone Feb 18, 2023
The new optional boolean will set traces_sample_rate to 1.0
automatically if not set yet. If false, this will also disable tracing
even if a sample rate or sampler is set.
@sl0thentr0py sl0thentr0py force-pushed the neel/enable-tracing branch from fd7daad to 2bf8dca Compare March 9, 2023 16:27
@sl0thentr0py sl0thentr0py merged commit 00843f3 into master Mar 9, 2023
@sl0thentr0py sl0thentr0py deleted the neel/enable-tracing branch March 9, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add enableTracing Option

4 participants