Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event processor in OpenTelemetry SpanProcessor to link errors and transactions #1983

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

sl0thentr0py
Copy link
Member

closes #1975

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2023

Codecov Report

Base: 98.10% // Head: 98.57% // Increases project coverage by +0.46% 🎉

Coverage data is based on head (74c5ef6) compared to base (b73abea).
Patch coverage: 55.55% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1983      +/-   ##
==========================================
+ Coverage   98.10%   98.57%   +0.46%     
==========================================
  Files          44      157     +113     
  Lines        1798     9920    +8122     
==========================================
+ Hits         1764     9779    +8015     
- Misses         34      141     +107     
Impacted Files Coverage Δ
...lemetry/lib/sentry/opentelemetry/span_processor.rb 95.55% <55.55%> (ø)
sentry-ruby/spec/sentry/scope/setters_spec.rb 97.52% <0.00%> (ø)
...y/spec/sentry/interfaces/request_interface_spec.rb 99.07% <0.00%> (ø)
sentry-ruby/lib/sentry/net/http.rb 100.00% <0.00%> (ø)
sentry-ruby/spec/sentry/rake_spec.rb 100.00% <0.00%> (ø)
sentry-ruby/lib/sentry-ruby.rb 96.47% <0.00%> (ø)
sentry-delayed_job/lib/sentry-delayed_job.rb 73.33% <0.00%> (ø)
...metry/spec/sentry/opentelemetry/propagator_spec.rb 100.00% <0.00%> (ø)
sentry-ruby/spec/sentry/integrable_spec.rb 100.00% <0.00%> (ø)
...c/sentry/sidekiq/sentry_context_middleware_spec.rb 100.00% <0.00%> (ø)
... and 104 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sl0thentr0py sl0thentr0py marked this pull request as ready for review January 11, 2023 12:15
Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sl0thentr0py sl0thentr0py merged commit bbfb651 into master Jan 16, 2023
@sl0thentr0py sl0thentr0py deleted the neel/otel-link-tx-error branch January 16, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link errors and transactions in sentry-opentelemetry
3 participants