Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sentry.add_global_event_processor API #1976

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

sl0thentr0py
Copy link
Member

Other SDKs allow adding global event processors without configuring scope, so this adds the same functionality.

closes #1974
(need it to implement #1975)

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2023

Codecov Report

Base: 98.61% // Head: 98.61% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (9c16bb2) compared to base (fb394a5).
Patch coverage: 96.96% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1976   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files         157      157           
  Lines        9880     9911   +31     
=======================================
+ Hits         9743     9774   +31     
  Misses        137      137           
Impacted Files Coverage Δ
sentry-ruby/lib/sentry-ruby.rb 95.88% <50.00%> (-0.55%) ⬇️
sentry-ruby/lib/sentry/scope.rb 100.00% <100.00%> (ø)
sentry-ruby/spec/sentry/scope_spec.rb 100.00% <100.00%> (ø)
sentry-ruby/lib/sentry/breadcrumb.rb 100.00% <0.00%> (+3.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good 👍 But it'd be better if we don't use class variable for it.

sentry-ruby/lib/sentry/scope.rb Outdated Show resolved Hide resolved
@sl0thentr0py sl0thentr0py merged commit b73abea into master Jan 9, 2023
@sl0thentr0py sl0thentr0py deleted the neel/global-event-processors branch January 9, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add global event processors
3 participants